On Fri Jun 19 04:39:45 2026 +0000, Huw Davies wrote:
The tests seem to succeed for me even without your implementation change, so that'll need looking at more. More generally, in cases like this, where the tests are simple, it's usually better to have a commit with the tests first, using `todo_wine`s as appropriate. Then follow that with the implementation change, removing the `todo_wine`s in the tests. That way it's clear that the implementation change is doing what the tests are testing. @huw thanks for reviewing.
You are correct that test succeed even without the patch so I must have mistaken a previous test build, which failed as expected, for changes pushed afterwards which pass erroneously after rebuilding tests. Latest commits have been reworked with `todo_wine` that introduces test fail which is removed for next commit containing patch per your suggestions. Sorry for inconvenience and thanks for test case guidance which I'll use going forward. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11083#note_143619