On Tue May 26 17:06:54 2026 +0000, Feli Rippmann wrote:
Thank you, I have now put the test and fix in one commit. I had originally separated them into two commits because of the [Patch guidelines](https://gitlab.winehq.org/wine/wine/-/wikis/Submitting-Patches#patch-guideli...) in the wiki. Is there any guideline on when to separate them and when not to, that I could use in the future? Yes, usually we separate the tests and the fix. Then, submit the tests first with a todo_wine. However, in this case, you can either introduce a todo_wine support in `check_sizes()` or merge the patches into one patch. Since the fix is small, adding todo_wine to `check_sizes()` seems unnecessary, and one patch is fine.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10809#note_141388