Re: [PATCH 0/3] MR11037: winex11: Create layout when falling back to fuzzy detection.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/winex11.drv/keyboard.c:
> +                   debugstr_a(layout), debugstr_a(variant), lang, klid );
>
> -                snprintf( buffer, ARRAY_SIZE(buffer), "%s:%s", layout, variant );
> -                create_layout_from_xkb( i, buffer, lang, klid );
> -            }
> -            XFree( names[i] );
> +            snprintf( buffer, ARRAY_SIZE(buffer), "%s:%s", layout, variant );
> +            create_layout_from_xkb( i, buffer, lang, klid );
> +
> +            if (names[i]) XFree( names[i] );
>          }
>
> XkbFreeKeyboard( xkb_desc, 0, True );
>      }
>
> -    kbd_layout = detect_keyboard_layout( display, mmp, xkb_group );
> We're not setting kbd_layout anymore after this, which is not going to work.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11037#note_141854