Re: [PATCH v6 0/10] MR10645: mf/topology_loader: Insert optional nodes after each branch is connected.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/mf/topology_loader.c:
> +            *down_node = node;
> +            *down_stream = stream;
> +            return S_OK;
> +        }
> +
> +        if (topology_node_get_type(node) == MF_TOPOLOGY_OUTPUT_NODE)
> +        {
> +            hr = MF_E_TOPO_UNSUPPORTED;
> +            break;
> +        }
> +
> +        if (!optional)
> +        {
> +            IMFTopologyNode_AddRef(optional = node);
> +            opt_stream = stream;
> +        }
> This looks wrong to me, stream gets updated when iterating but it's used once as output stream index and then gets updated from input stream index. Nodes input / output streams are mostly unrelated?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10645#note_137736