On Mon May 11 09:56:08 2026 +0000, Zhiyi Zhang wrote:
The tests for TVN_ITEMCHANGING and TVN_ITEMCHANGED are still mixed with other tests. So you have things like parent_rootnone_select_seq_v6 that include multiple pairs of TVN_ITEMCHANGING and TVN_ITEMCHANGED. The ideal way is to test TVN_ITEMCHANGING and TVN_ITEMCHANGED specifically. For example, when there is only one child item, there will be only **one pair** of TVN_ITEMCHANGING and TVN_ITEMCHANGED. This way, the tests would be much cleaner and clearly separated from existing tests. Various treeview operations send TVN_ITEMCHANGING+TVM_ITEMCHANGED to parent in v6 mode but omit them in v5. Various tests must simply use different parent message sequences in v6 mode.
Additionally, test_select() wasn't done at all for v6 prior to my changes - presumably because it was broken (all recorded message sequences were valid for v5 but not v6). If this is what you want, I'll discard all changes I made to test_select() & test_get_set_item() - also drop test_select() from v6 tests. But I don't really think this is a good idea. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10451#note_139602