On Tue May 5 11:32:27 2026 +0000, Mykola Mykhno wrote:
Thank you for the review! I understand the general part better now. For some reason, after reading the Wine developer documentation, I thought tests should be in a separate commit only for significant changes. I just read the documentation on winecfg, and now I understand why version-dependent paths should be avoided. Yes, simpler solution would be better in this case. I updated the merge request, so it should be better now. we want every commit to pass the non regression tests (so that, eg, bisecting later on will not fail)
so you need to add @todo_wine@ in the cmd.exp file for the failing tests in first commit, and remove them (for the tests that now pass) in the second commit -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10797#note_138864