June 26, 2026
6:21 a.m.
On Fri Jun 26 06:02:22 2026 +0000, Etaash Mathamsetty wrote:
I don't think this is right, if the compositor decides to move our popup from where we want it, then we will not be able to reposition the popup (since returning false here would would prevent wayland_surface_reconfigure_geometry from getting called). This would also prevent it from getting mapped on the first frame if the compositor decided to move the popup. The positioning is now done in `wayland_surface_make_popup`, not `wayland_surface_reconfigure_geometry`. Returning FALSE here makes sure `wayland_configure_window` will need to process it and update the Win32 state with the new popup position.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/11248#note_144292