On Tue Jun 30 10:33:21 2026 +0000, Martin Storsjö wrote:
Erm, sorry, I must have been confused in my comment above. Even with the naming `HWCAP_ARM_NEON`, glibc and musl both define it, but with differing spelling. So even with that choice we do need an `#ifndef` it we don't want it to warn. So I think we do need a fallback, with `#ifndef`, in either case. There's no single name that is universally defined by this set of three different system headers - unless we readd `<asm/hwcap.h>`, which is needed on glibc to define `HWCAP_NEON`. Ah, I had been looking at `asm/hwcap.h` when I wrote the code and forgot to check `bits/hwcap.h` when we switched to using that.
Maybe we could just use `HWCAP_ARM_NEON` without any fallback define, since `bits/hwcap.h` from glibc and musl both define it and we're not supporting any toolchains old enough to need it defined. That leaves out FreeBSD, but honestly I don't think there's anyone building or using Wine on ARM32 FreeBSD. We didn't have any feature detection code path for it before either. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11267#note_144557