On Tue Apr 21 19:43:38 2026 +0000, Jan Robert Gerigk wrote:
Pipeline showed 13 failures from my last push. Analysed locally: 6/10 (now 6/9): my "cleaner" SetupDi pattern from the previous review pass was wrong for Wine. SetupDiEnumDeviceInfo on a DIGCF_DEVICEINTERFACE set returned no items. Fixed by switching to SetupDiEnumDeviceInterfaces + SetupDiGetDeviceInterfaceDetail-with-NULL-detail to extract the bus device's SP_DEVINFO_DATA. Setupapi devinst test still 0 failures locally. 8/10 (the Siblings test): the transient second-child approach broke kernel-side counters in driver_pnp.c (hardcoded remove_device_count == 0) and the user-mode notification handlers (hardcoded "Wine#Test #1" strings). I dropped the test from this MR. The Siblings property storage commit (now 7/9) stays in. If that is OK with you, I would submit a dedicated Siblings test as a follow-up MR with its own bus-test fixture so the existing test_pnp_devices invariants stay intact? Series rebased onto current master (was 34 commits behind), 9 commits total now. Running some tests again locally, should by ready any time soon. This merge request seems to have stalled. Is there anything else I need to do?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10604#note_139589