April 3, 2026
1:59 p.m.
On Fri Apr 3 11:32:44 2026 +0000, Vishnunithyasoundhar S wrote:
I have addressed all ur comments @sgwaki Pls have a look thanks. Also currently, some tests that my code change didnt even touch are failing. Am I supposed to look into them too? Ideally, those failures should be verified, but if you're confident that your change cannot affect them, it's fine to ignore them. Personally, I would at least take a quick look to confirm that the failing tests don't use the API you modified.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_134950