Rémi Bernon (@rbernon) commented about dlls/win32u/vulkan.c:
case VK_STRUCTURE_TYPE_PERFORMANCE_QUERY_SUBMIT_INFO_KHR: break; case VK_STRUCTURE_TYPE_PROTECTED_SUBMIT_INFO: break; case VK_STRUCTURE_TYPE_TIMELINE_SEMAPHORE_SUBMIT_INFO: - if (timeline->sType) ERR( "Duplicated timeline semaphore submit info!\n" ); + if (timeline->sType == VK_STRUCTURE_TYPE_TIMELINE_SEMAPHORE_SUBMIT_INFO) + ERR( "Duplicated timeline semaphore submit info.\n" ); + else if (timeline->sType) + FIXME( "Both d3d12 fence and timeline submit info.\n" ); +
Can both even be added at the same time, what is it supposed to do? I think we can just keep the error message and use the same check in VK_STRUCTURE_TYPE_D3D12_FENCE_SUBMIT_INFO_KHR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11175#note_143582