Re: [PATCH 0/1] MR10365: kernelbase: Add language specific resource support.

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about dlls/kernelbase/loader.c:
> +    for (i = 0; i < MAX_PATH; i++) {
> +        module_name[i] = 0;
> +        mui_name[i] = 0;
> +    }
> +
> +    /* Acquire the base resource file name */
> +
> +    if (!(GetModuleFileNameW(module, module_name, MAX_PATH))) {
> +        TRACE ("Module file name was not found - returning with source module\n");
> +        SetLastError(save_error);
> +        return module;
> +    }
> +	
> +    /*  Stay with the original module reference if this file is not an executable file. */
> +
> +    if (!(wcsstr(module_name, L".exe"))) 
> Okay we definitely need a test with an uppercase filename.

And a test at all.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10365#note_134080