On Tue Apr 28 03:33:34 2026 +0000, Zhiyi Zhang wrote:
I don't like that the TVN_ITEMCHANGING and TVN_ITEMCHANGED message tests are mixing with other tests. Please separate them into a new test function. For example, if selecting or setting one item triggers TVN_ITEMCHANGING and TVN_ITEMCHANGED, then you test specifically that, not adding the tests where there are multiple unnecessary child items. Moved new tests specifically testing TVN_ITEMCHANGING functionality to a new function.
The rest should be good as it is? I added parent message sequences to various existing tests instead of inventing new, I don't think there's any point in duplicating them with/without parent message sequences? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10451#note_138712