Re: [PATCH 0/1] MR10536: vbscript: Fast-path stack_pop_bool for VT_BOOL.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/vbscript/interp.c:
> -    }
> -    else
> -    {
> +        break;
> +    default: {
> +        VARIANT v;
>          V_VT(&v) = VT_EMPTY;
> -        if (SUCCEEDED(hres = VariantChangeType(&v, val.v, VARIANT_LOCALBOOL, VT_BOOL)))
> +        hres = VariantChangeType(&v, val.v, VARIANT_LOCALBOOL, VT_BOOL);
> +        if(SUCCEEDED(hres))
>              *b = !!V_BOOL(&v);
> +        break;
> +    }
>      }
>
> release_val(&val);
> It is not a big deal, but since this is all about performance, you could move `release_val` to the default case to skip it for fast paths that do not need it.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10536#note_134973