April 15, 2026
10:13 p.m.
One thing (I did mention this, but no worries): can we add tests for 1/7, 3/7, and 4/7? 2/7: ``` + { + WCHAR parent_id[MAX_DEVICE_ID_LEN]; + if (!get_device_instance_id( parent_device, parent_id )) + SetupDiSetDevicePropertyW( set, &sp_device, &DEVPKEY_Device_Parent, DEVPROP_TYPE_STRING, + (BYTE *)parent_id, (wcslen( parent_id ) + 1) * sizeof(WCHAR), 0 ); + } ``` We don't need a scope for this, just put parent_id[] at the beginning. Same for 3/7. 7/7: ``` + ok(buffer_w[0] != 0, "got empty parent ID\n"); + trace("DEVPKEY_Device_Parent: %s\n", debugstr_w(buffer_w)); ``` Can't we test the actual contents? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10604#note_136417