On Mon May 25 08:35:46 2026 +0000, Zhiyi Zhang wrote:
At this commit, the test fails, so it will introduce CI failures. You can put the fix in the same commit since the fix is pretty small. ``` mrebar.c:720: Test failed: invalid rect (client) (0,0)-(672,111) - expected (0,0)-(672,65) mrebar.c:720: Test failed: Height mismatch for row 0 - 65 vs 111 mrebar.c:720: Test failed: invalid rect (band) (0,0)-(90,111) - expected (0,0)-(90,65) mrebar.c:720: Test failed: invalid rect (band) (90,0)-(180,111) - expected (90,0)-(180,65) mrebar.c:720: Test failed: invalid rect (band) (180,0)-(672,111) - expected (180,0)-(672,65) ``` Thank you, I have now put the test and fix in one commit. I had originally separated them into two commits because of the [Patch guidelines](https://gitlab.winehq.org/wine/wine/-/wikis/Submitting-Patches#patch-guideli...) in the wiki. Is there any guideline on when to separate them and when not to, that I could use in the future?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10809#note_141355