Re: [PATCH 0/1] MR11105: winewayland: Fix handling of numlock and right shift.

[Rémi Bernon (＠rbernon)]

On Wed Jun 10 08:32:09 2026 +0000, Etaash Mathamsetty wrote:
> ```
>     struct send_input_keyboard_test rshift_scan[] =
>     {
>         {.scan = 0x36, .flags = KEYEVENTF_SCANCODE, .expect_state =
> {[VK_SHIFT] = 0x80, [VK_LSHIFT] = 0x80},
>          .expect = {KEY_HOOK(WM_KEYDOWN, 0x36, VK_RSHIFT),
> KEY_MSG(WM_KEYDOWN, 0x36, VK_SHIFT), {0}}},
>         {.scan = scan, .flags = KEYEVENTF_SCANCODE, .expect_state =
> {[VK_SHIFT] = 0x80, [VK_LSHIFT] = 0x80, /*[vkey] = 0x80*/},
>          .expect = {KEY_HOOK(WM_KEYDOWN, scan, vkey),
> KEY_MSG(WM_KEYDOWN, scan, vkey), WIN_MSG(WM_CHAR, wch_shift, MAKELONG(1,
> scan)), {0}}},
>         {.scan = scan, .flags = KEYEVENTF_SCANCODE | KEYEVENTF_KEYUP,
> .expect_state = {[VK_SHIFT] = 0x80, [VK_LSHIFT] = 0x80},
>          .expect = {KEY_HOOK(WM_KEYUP, scan, vkey), KEY_MSG(WM_KEYUP,
> scan, vkey), {0}}},
>         {.scan = 0x36, .flags = KEYEVENTF_SCANCODE | KEYEVENTF_KEYUP,
>          .expect = {KEY_HOOK(WM_KEYUP, 0x36, VK_RSHIFT),
> KEY_MSG(WM_KEYUP, 0x36, VK_SHIFT), {0}}},
>         {0},
>     };
> ```

Hmm, then maybe wineserver should check hardware input origin (IMO_HARDWARE vs IMO_INJECTED) to decide to translate to VK_RSHIFT even without extended bit.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11105#note_142603