Re: [PATCH v5 0/4] MR10261: Fix toolbar wrapping issues

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c:
> UnregisterClassW(wc.lpszClassName, 0);
>  }
>
> +static void AddButton(HWND tb, const char *text, int id)

I am not against adding this helper. But this is not generic enough. For example, style and state are hard-coded. You need to either make this generic enough so that future tests can use this and put this at the top of the file, or you can put the buttons you want to add in a TBBUTTON array and use TB_ADDBUTTONSA directly. For example, see test_sizes().

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10261#note_146045