April 7, 2026
8:25 p.m.
On Wed Apr 8 01:21:04 2026 +0000, Hoshino Lina wrote:
This is a server call. If the server sends a SIGUSR1 here and we do not handle it, presumably the server could deadlock waiting for the ack to the SIGUSR1 while we make the call. Even if that wouldn't happen in the trivial case (not sure how the server is implemented in terms of async/etc), one could imagine an application code sequence that would create this dependency and deadlock (think: two threads trying to set each others' context). I moved the unblock inside the if, since I think that makes more sense.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10419#note_135398