Re: [PATCH v54 0/2] MR10291: Fix GetModuleFileName string termination
Alexandre Julliard (@julliard) commented about dlls/kernel32/tests/loader.c:
+static void test_getmodulefilenamew_string_termination(void) +{ + WCHAR dll_name[MAX_PATH]; + size_t dll_name_len, dll_name_term; + DWORD rv, err; + + SetLastError(0xdeadbeef); + GetModuleFileNameW(NULL, dll_name, MAX_PATH); + err = GetLastError(); + ok(err == ERROR_SUCCESS, "error getting path for NULL module: %lu\n", err); + dll_name_len = wcslen(dll_name); + ok(dll_name_len > 0, "can't get path for NULL module\n"); + + memset(dll_name, '*', sizeof(dll_name)); + SetLastError(0xdeadbeef); + rv = GetModuleFileNameW(NULL, dll_name, dll_name_len); You should test the return value.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_135279
participants (1)
-
Alexandre Julliard (@julliard)