Re: [PATCH v54 0/2] MR10291: Fix GetModuleFileName string termination

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about dlls/kernel32/tests/loader.c:
> +
> +    SetLastError(0xdeadbeef);
> +    GetModuleFileNameW(NULL, dll_name, MAX_PATH);
> +    err = GetLastError();
> +    ok(err == ERROR_SUCCESS, "error getting path for NULL module: %lu\n", err);
> +    dll_name_len = wcslen(dll_name);
> +    ok(dll_name_len > 0, "can't get path for NULL module\n");
> +
> +    memset(dll_name, '*', sizeof(dll_name));
> +    SetLastError(0xdeadbeef);
> +    rv = GetModuleFileNameW(NULL, dll_name, dll_name_len);
> +    err = GetLastError();
> +    ok(err == ERROR_INSUFFICIENT_BUFFER, "didn't get expected error getting path for NULL module with short buffer: %lu\n", err);
> +    dll_name_term = wcsnlen(dll_name, MAX_PATH);
> +    ok(dll_name_term > 0, "can't get path for NULL module with short buffer, dll_name_term=%Iu\n", dll_name_term);
> +    ok(dll_name_term == dll_name_len - 1, "incorrect path termination for NULL module with short buffer. Expected %Iu got %Iu. rv=%lu\n", dll_name_len - 1, dll_name_term, rv);
> It doesn't seem useful to test length twice. You should also test that the buffer has not been overflowed.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_135278