http://bugs.winehq.org/show_bug.cgi?id=6677
------- Additional Comments From the3dfxdude(a)gmail.com 2006-13-11 15:39 -------
Created an attachment (id=4081)
--> (http://bugs.winehq.org/attachment.cgi?id=4081&action=view)
printf buffer handling fix
This is maybe the way to do it. It would be really problematic to guess the
size exactly, so the way we ought to do it is a simple way and guess the
largest possible buffer size required when we have to deal with precision or
large fields.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=6677
------- Additional Comments From the3dfxdude(a)gmail.com 2006-13-11 14:51 -------
I can fix pf_integer_conv easily. The most important thing is accurately
determining the buffer size required in vsnprintf first.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=6677
------- Additional Comments From the3dfxdude(a)gmail.com 2006-13-11 14:49 -------
Sorry it does, I got it confused with another case.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=6677
------- Additional Comments From the3dfxdude(a)gmail.com 2006-13-11 14:44 -------
I'm not saying that you're wrong. I'm saying that size checking is unneccesary
in pf_integer_conv as is. All that function does is return a string
representation of a 64-bit integer. It doesn't output fields, precision, or
signs, etc. If you want to see the maximum output length of the function, do
something like this:
printf("%I64u\n", (LONGLONG)-1);
If what was converted for I64u was within 40, then that is all that is necessary.
Octal is slightly different, but it's still within bounds. I know all this
because I wrote the function and I checked to see if the function's output fit
in the buffer in all cases.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=6401
------- Additional Comments From kopalnia.dzwieku(a)wp.pl 2006-13-11 14:30 -------
I would like to find anything suspicious but...
Can you explain how to look at warn+all chanells?
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=6516
------- Additional Comments From kopalnia.dzwieku(a)wp.pl 2006-13-11 14:30 -------
sorry, I noticed that you put finale version
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=2819
kelfe(a)gmx.de changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kelfe(a)gmx.de
------- Additional Comments From kelfe(a)gmx.de 2006-13-11 14:29 -------
*** Bug 5169 has been marked as a duplicate of this bug. ***
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=5169
kelfe(a)gmx.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |DUPLICATE
------- Additional Comments From kelfe(a)gmx.de 2006-13-11 14:29 -------
same issue as 2819
*** This bug has been marked as a duplicate of 2819 ***
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=6677
------- Additional Comments From samuel.howard.dennis(a)gmail.com 2006-13-11 14:27 -------
static void pf_integer_conv( char *buf, pf_flags *flags, LONGLONG x )
{
char tmp[40];
...
k = flags->Precision - i;
while( k-- > 0 )
tmp[i++] = '0';
I'm not just making random accusations, and if you'd check the code you'd see
that everything I've asserted is true.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.