http://bugs.winehq.org/show_bug.cgi?id=7544
--- Comment #29 from Erich Hoover <ehoover(a)mines.edu> 2008-02-05 18:12:10 ---
(In reply to comment #28)
> Sorry, I didn't know that you couldn't use code reuse (since the committed
> version of MoveFileWithProgressW relies on other Windows API calls), is there a
> reason this?
>
That's the way Alexandre wants it (also MoveFile uses Nt* calls, which are
lower level). For some historical background I think you'll find the
similarities between my original Feburary 2007 patch and your suggested patch
interesting (yes, this patch has been on the table for almost a year):
http://winehq.org/pipermail/wine-patches/2007-February/036394.html
> Your current patch for this bug doesn't handle moving file over different mount
> points.
>
Quite so, but neither does MoveFile.
> Also those gotos aren't helping your cause.
>
Wine is not a college exercise in flow statements. If you take a look around
the code base "goto" is the standard practice for handling error conditions.
This practice puts all cleanup code in one centralized location so that changes
down the road do not neglect to clean something up.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=3768
Dan Kegel <dank(a)kegel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dank(a)kegel.com
--- Comment #13 from Dan Kegel <dank(a)kegel.com> 2008-02-05 17:51:03 ---
Agreed, if it can be tested by anybody, perhaps
we should leave it open even if the original poster abandoned it.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=3254
Ben McCann <benjamin.j.mccann(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |benjamin.j.mccann(a)gmail.com
--- Comment #41 from Ben McCann <benjamin.j.mccann(a)gmail.com> 2008-02-05 17:39:34 ---
Yuval said in bug 4538 (http://bugs.winehq.org/show_bug.cgi?id=4538#c7) that he
was working on a fix, but I have heard nothing. I'd also love for this to get
fixed since it affects quite a few apps.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=7544
brendan <bed88012(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bed88012(a)gmail.com
--- Comment #28 from brendan <bed88012(a)gmail.com> 2008-02-05 17:20:00 ---
(In reply to comment #27)
>
> If Alexandre would have permitted using Windows API calls then this would have
> been patched a long time ago. That is why the latest patch is different from
> the older ones, see
> http://winehq.org/pipermail/wine-devel/2007-October/059948.html for details.
>
Sorry, I didn't know that you couldn't use code reuse (since the committed
version of MoveFileWithProgressW relies on other Windows API calls), is there a
reason this?
Your current patch for this bug doesn't handle moving file over different mount
points. Also those gotos aren't helping your cause.
> Brendan, I don't think you can use printf inside kernel32.dll.
> Use TRACE instead if you really want to log something.
>
> I think you can leave off the bit about the three unimplemented flags.
>
> Also, it's "therefore", not "there for".
yeah, I relied that after I attached it to this bug.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=6224
--- Comment #22 from Neil Skrypuch <ns03ja(a)brocku.ca> 2008-02-05 15:51:32 ---
(In reply to comment #21)
>
> Can you try in a virtual desktop?
>
The results are identical in a virtual desktop.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=3254
Dan Kegel <dank(a)kegel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dank(a)kegel.com
--- Comment #40 from Dan Kegel <dank(a)kegel.com> 2008-02-05 12:21:38 ---
The log still shows
fixme:secur32:schan_InitializeSecurityContextA stub
and there are no plans yet to implement that
part of secur32 that I know of.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=6579
Austin English <austinenglish(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #14 from Austin English <austinenglish(a)gmail.com> 2008-02-05 12:03:38 ---
Closing.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=6579
Austin English <austinenglish(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED
--- Comment #13 from Austin English <austinenglish(a)gmail.com> 2008-02-05 12:03:25 ---
Demo works fine, and no response from reporter. Resolving fixed.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.