http://bugs.winehq.org/show_bug.cgi?id=824
------- Additional Comments From tony_lambregts(a)telusplanet.net 2004-10-10 23:44 -------
Patches tend to bit rot here. If you want them reviewed it is probably better
to submit them to wine-devel. Also patches are supposed to be in diff -u
format. For more information please refer to the following link.
http://www.winehq.org/site/docs/wine-devel/patches
Please include a link to this bug report in your post.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=2508
------- Additional Comments From shiva(a)sewingwitch.com 2004-10-10 16:34 -------
I traced the call in wineserver, here's the output:
0009: create_file( access=40000000, inherit=0, sharing=00000007, create=1,
options=00004010, attrs=00000000,
filename="/home/vengeance/.wine/dosdevices/z:/home/vengeance/Server/Program/Bin/" )
0009: create_file() = FILE_IS_A_DIRECTORY { handle=(nil) }
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=2508
Summary: CreateFile(directory_name,GENERIC_WRITE,...) returns
STATUS_FILE_IS_A_DIRECTORY
Product: Wine
Version: 20040914
Platform: PC
OS/Version: Linux
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: wine-files
AssignedTo: wine-bugs(a)winehq.org
ReportedBy: shiva(a)sewingwitch.com
While testing the beta Tribes: Vengeance dedicated server, I found that it tests
for a writable directory with this sequence:
000b:Call kernel32.CreateFileW(10415fc0
L"Z:\\home\\vengeance\\Server\\Program\\Bin\\",40000000,00000007,00000000,00000003,02000000,00000000)
ret=1015b46d
000b:Call ntdll.RtlIsDosDeviceName_U(10415fc0
L"Z:\\home\\vengeance\\Server\\Program\\Bin\\") ret=554b4506
000b:Ret ntdll.RtlIsDosDeviceName_U() retval=00000000 ret=554b4506
000b:Call ntdll.RtlDosPathNameToNtPathName_U(10415fc0
L"Z:\\home\\vengeance\\Server\\Program\\Bin\\",559bebb0,00000000,00000000)
ret=554b42c7
000b:Ret ntdll.RtlDosPathNameToNtPathName_U() retval=00000001 ret=554b42c7
000b:Call
ntdll.NtCreateFile(559beba4,40000000,559bebb8,559beba8,00000000,00000000,00000007,00000001,00004010,00000000,00000000)
ret=554b438f
000b:Ret ntdll.NtCreateFile() retval=c00000ba ret=554b438f
000b:Call ntdll.RtlNtStatusToDosError(c00000ba) ret=554b43bd
000b:Ret ntdll.RtlNtStatusToDosError() retval=00000005 ret=554b43bd
000b:Call ntdll.RtlFreeUnicodeString(559bebb0) ret=554b43cc
000b:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=554b43cc
000b:Ret kernel32.CreateFileW() retval=ffffffff ret=1015b46d
As you can see, this fails in NtCreateFile() (create_file() in server/file.c).
Running the program in Win2k with strace, I see this and think it's the
comparable call:
3169 2264 1668 NtCreateFile (0x40100080, {24, 0, 0x40, 0, 2288836,
"\??\K:\Games\tvserver\Server\Program\Bin\"}, 0x0, 0, 7, 1, 16416, 0, 0, ...
124, {status=0x0, info=1}, ) == 0x0
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=824
randy.galbraith(a)cox.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #697 is|0 |1
obsolete| |
------- Additional Comments From randy.galbraith(a)cox.net 2004-10-10 15:02 -------
Created an attachment (id=698)
--> (http://bugs.winehq.org/attachment.cgi?id=698&action=view)
Storage of REG_MULTI_SZ changed from str(7) to hex(7)
Whoops! The last patch was wrong, it used "hex:" instead of "hex(7):", thus
losing the data type in the process of storing a REG_MULTI_SZ. This new patch
corrects that issue and is actually simpler. I've also expanded the test
program (see link off members.cox.net above) to read back and compare the
values.
Best regards,
-Randy Galbraith
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=824
------- Additional Comments From randy.galbraith(a)cox.net 2004-10-10 13:14 -------
Created an attachment (id=697)
--> (http://bugs.winehq.org/attachment.cgi?id=697&action=view)
Proposed patch to wine/server/registry.c 1.60
This patch proposes changes to wine/server/registry.c to handle REG_MULTI_SZ as
a type of REG_BINARY instead of the current REG_SZ mapping. This is my first
ever proposed patch to the Wine project, hence it will require careful review
by the Wine experts.
I've tested this change on my system and it appears to work correctly. The
first time I ran my test program I got the following output from Wine:
Line 4944: Malformed value '"Dependent Files"=str(7):""'
Line 88: Malformed value '"Empty Value0"=str(7):""'
Line 89: Malformed value '"Empty Value1"=str(7):""'
Line 90: Malformed value '"Empty Value2"=str(7):"\1"'
Line 91: Malformed value '"Empty Value3"=str(7):"one\0two\0three\0"'
On the second run, there was no output.
Best regards,
-Randy Galbraith
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=2507
tony_lambregts(a)telusplanet.net changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |http://appdb.winehq.org/appv
| |iew.php?appId=70
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=2506
tony_lambregts(a)telusplanet.net changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |http://appdb.winehq.org/appv
| |iew.php?appId=70
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=1142
------- Additional Comments From wine(a)deesconsulting.com 2004-10-10 10:51 -------
OK, I'm using this bug as scratchspace atm, so this may or may not be correct.
This message (http://winehq.org/hypermail/wine-devel/2003/03/0481.html) is the
beginning of a long thread explaining file locking in wine.
If this message (http://winehq.org/hypermail/wine-devel/2003/03/0577.html) is
correct, then the problem appears to be that mandatory locks in windows apps
are being mapped onto advisory locks in linux. So the solution could be for
wine to check for advisory locks every time before opening a file, and, if a
lock exists, enforce mandatory locking on windows apps and return an error.
I don't know if that's right or if it's possible, but I want to write this
down before I sleep on it ;)
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.winehq.org/show_bug.cgi?id=2422
------- Additional Comments From bugzilla(a)jonathan-glaschke.de 2004-10-10 09:44 -------
I use FreeBSD 5.2.1 with Wine-20040914, same Problem.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.