http://bugs.winehq.com/show_bug.cgi?id=1273
Summary: HEAP_strdupAtoW in dlls/winspool/info.c
Product: Wine
Version: CVS
Platform: PC
OS/Version: Linux
Status: UNCONFIRMED
Severity: critical
Priority: P2
Component: wine-misc
AssignedTo: wine-bugs(a)winehq.com
ReportedBy: dan(a)willemsen.us
There appears to be a HEAP_strdupAtoW call in dlls/winspool/info.c which is
blocking me from building the current CVS.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://bugs.winehq.com/show_bug.cgi?id=1273>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://bugs.winehq.com/show_bug.cgi?id=1272
------- Additional Comments From dclark(a)akamail.com 2003-02-11 19:50 -------
It looks like SW_SHOWMINIMIZED should be setting a flag to not resize the top
level window. Like this.
Index: dlls/x11drv/winpos.c
===================================================================
RCS file: /home/wine/wine/dlls/x11drv/winpos.c,v
retrieving revision 1.63
diff -u -r1.63 winpos.c
--- dlls/x11drv/winpos.c 8 Jan 2003 21:09:26 -0000 1.63
+++ dlls/x11drv/winpos.c 12 Feb 2003 01:39:59 -0000
@@ -1237,7 +1240,7 @@
/* fall through */
case SW_SHOWMINIMIZED:
case SW_FORCEMINIMIZE: /* FIXME: Does not work if thread is hung. */
- swp |= SWP_SHOWWINDOW;
+ swp |= SWP_SHOWWINDOW | SWP_WINE_NOHOSTMOVE;
/* fall through */
case SW_MINIMIZE:
swp |= SWP_FRAMECHANGED;
@@ -1296,7 +1299,7 @@
swp |= SWP_NOACTIVATE | SWP_NOZORDER;
SetWindowPos( hwnd, HWND_TOP, newPos.left, newPos.top,
- newPos.right, newPos.bottom, LOWORD(swp) );
+ newPos.right, newPos.bottom, swp );
if (cmd == SW_HIDE)
{
/* FIXME: This will cause the window to be activated irrespective
The next problem is that somewhere, the SW_MINIMIZE client style is removed, but
the client window is not mapped. If you use just the above patch, you will see
the missing interior (client) area. This patch explicitely maps the client area,
but it kind of masks the original problem.
Index: dlls/x11drv/window.c
===================================================================
RCS file: /home/wine/wine/dlls/x11drv/window.c,v
retrieving revision 1.50
diff -u -r1.50 window.c
--- dlls/x11drv/window.c 30 Jan 2003 01:07:43 -0000 1.50
+++ dlls/x11drv/window.c 12 Feb 2003 01:49:42 -0000
@@ -587,7 +587,7 @@
if (was_mapped && !is_client_window_mapped( win ))
XUnmapWindow( display, data->client_window );
XConfigureWindow( display, data->client_window, mask, &changes );
- if (!was_mapped && is_client_window_mapped( win ))
+ if (is_client_window_mapped( win ))
XMapWindow( display, data->client_window );
wine_tsx11_unlock();
}
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://bugs.winehq.com/show_bug.cgi?id=1272>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://bugs.winehq.com/show_bug.cgi?id=1272
------- Additional Comments From dclark(a)akamail.com 2003-02-11 12:03 -------
Hmm, what I am seeing now is that sometimes the contents of the Window are
painted when I open and resize it, and sometimes they are not. Apparently
somewhat random, or at least no obvious cause that I can see.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://bugs.winehq.com/show_bug.cgi?id=1272>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://bugs.winehq.com/show_bug.cgi?id=1266
------- Additional Comments From dclark(a)akamail.com 2003-02-10 19:56 -------
The patch has been submitted. It makes sense (at least to me :-), and I tested
it with a bunch of apps too.
And yes, the window insisting on being on top is a "feature", and separate from
this bug.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://bugs.winehq.com/show_bug.cgi?id=1266>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://bugs.winehq.com/show_bug.cgi?id=1266
------- Additional Comments From pmcnett(a)pm-sc.com 2003-02-10 19:38 -------
Yes Duane, confirmed. Your second patch in bug 1265 fixes this WAIT WINDOW
problem as well. Same issue however with the window appearing on top of any
foreground application on any desktop workspace.
Are you going to submit your patch to be committed to CVS or did you need to
do more testing first?
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://bugs.winehq.com/show_bug.cgi?id=1266>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://bugs.winehq.com/show_bug.cgi?id=1265
------- Additional Comments From pmcnett(a)pm-sc.com 2003-02-10 19:35 -------
I didn't try your first fix but the second works!! This is great for Visual
FoxPro and Wine...
One thing though, not sure if this should be a separate bug report or not. If
I display some ToolTipText, and then switch to a different application, the
ToolTipText will be displaying on top of the foreground app's windows as well.
Actually, the ToolTipText will be on every desktop workspace, on top of all
other windows. I had previously noticed this phenomenon for dockable windows
that were currently undocked in the VFP IDE, so I'm assuming this is a
separate issue entirely and will likely file a separate bug report in a couple
weeks...
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://bugs.winehq.com/show_bug.cgi?id=1265>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://bugs.winehq.com/show_bug.cgi?id=1258
------- Additional Comments From andi(a)rhlx01.fht-esslingen.de 2003-02-10 18:36 -------
Hi, please attach a full --debugmsg +relay logfile.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://bugs.winehq.com/show_bug.cgi?id=1258>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://bugs.winehq.com/show_bug.cgi?id=1260
andi(a)rhlx01.fht-esslingen.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
everconfirmed|0 |1
------- Additional Comments From andi(a)rhlx01.fht-esslingen.de 2003-02-10 18:34 -------
Hi, please attach a --debugmsg +server logfile.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://bugs.winehq.com/show_bug.cgi?id=1260>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://bugs.winehq.com/show_bug.cgi?id=570
------- Additional Comments From andi(a)rhlx01.fht-esslingen.de 2003-02-10 18:10 -------
OK, just submitted a fix (add GetSystemMetrics(SM_CYCAPTION) to vertical window
size).
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://bugs.winehq.com/show_bug.cgi?id=570>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://bugs.winehq.com/show_bug.cgi?id=291
andi(a)rhlx01.fht-esslingen.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From andi(a)rhlx01.fht-esslingen.de 2003-02-10 18:09 -------
OK, just submitted a fix (add GetSystemMetrics(SM_CYCAPTION) to vertical window
size), fixing.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://bugs.winehq.com/show_bug.cgi?id=291>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.