http://bugs.winehq.org/show_bug.cgi?id=32003
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|wine-bugs@winehq.org |fgouget@codeweavers.com
--- Comment #1 from François Gouget fgouget@codeweavers.com 2012-10-24 17:24:32 CDT --- The logic for UpdateStatus() and Check(), where it is duplicated, is broken: if a task failed its step is marked as failed but the job won't be marked as failed unless the step was a build step. Presumably this was done this way to avoid having test failures cause a job to be marked as failed. However a task status only reflects whether the task ran as expected. So if there are test failures the TestFailures field will be non-zero and the Status 'completed'.
I will send a patch to fix this and deduplicate the code.