[Bug 50036] Remaining issues in Bugs in ntdll-Junction_Points in staging

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50036

--- Comment #16 from Martin Storsjö  ---
(In reply to Erich E. Hoover from comment #15)
> (In reply to Martin Storsjö from comment #14)
> > ...
> > Hmm, either I'm doing something wrong (I didn't apply all of wine-staging, I
> > just applied ntdll-Junction_Points and its dependencies ntdll-DOS_Attributes
> > and ntdll-NtQueryEaFile), or there's still something missing - the attached
> > test case now outputs this:
>
> No, it's probably that I made a mistake - try removing this block in
> server/fd.c:
> ===
> #if defined(O_SYMLINK)
>         /* if we tried to open a dangling symlink then try again with
> O_SYMLINK */
>         else if (errno == ENOENT)
>         {
>             fd->unix_fd = open( name, rw_mode | O_SYMLINK | (flags &
> ~O_TRUNC), *mode );
>         }
> #endif

Thanks! That did indeed fix the remaining issue here.

With this in place, I have only a few issues relating to symlink handling left
- I'll file separate issues for those.