https://bugs.winehq.org/show_bug.cgi?id=46470
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick@piezo-forte.be
--- Comment #23 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- You should at least split the big patch into smaller patchset that adds new features incrementally.
I'd split the function definitions into groups of related functions (*BufferRect(), EnqueueSVM*(), etc.) and add them as separate patches. I'd make sure each patchset applies and compiles cleanly. I'd submit one patchset at a time in the appropriate order and wait for one patchset to be accepted before submitting the next.
Here is how it'd look like:
First patchset: - Patches to declare and define new opencl 1.1 functions;
Second patchset: - Patches to declare and define new opencl 1.2 functions; - Patch to modify existing functions for 1.2 (=add the #ifdef CL_VERSION_1_2/1_1} alternatives);
Third patchset: - Patches to declare and define new opencl 2.0 functions; - Patch to modify existing functions for 2.0 (=add the #ifdef CL_VERSION_2_0/1_* alternatives);
etc.