[Bug 38841] New: PunkBuster 'PnkBstrB.exe' initialization fails (K32EnumProcessModules write to NULL pointer)

https://bugs.winehq.org/show_bug.cgi?id=38841

Bug ID: 38841
           Summary: PunkBuster 'PnkBstrB.exe' initialization fails
                    (K32EnumProcessModules write to NULL pointer)
           Product: Wine
           Version: 1.7.46
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

PunkBuster bundled with the game APB Reloaded failed to initialize PnkBstrB.exe
on my system.

--- +relay output ---
...
0031:Call KERNEL32.K32EnumProcessModules(ffffffff,00000000,00100000,0076e9a8)
ret=0044ef87
0031:Call KERNEL32.UnhandledExceptionFilter(0076e4c8) ret=7bc99dad
...
--- end +relay output ---

+relay debug output shows that PnkBstrB.exe call
kernel32.K32EnumProcessModules() with a NULL pointer as parameter 'lphModule'
and a non-zero value in parameter 'cb'. The current Wine code does not check if
lphModule is NULL, it writes module information in lphModule until cb size is
not enough. Writing to NULL pointer raises the exception.

I first tried to put this code in the K32EnumProcessModules() function:

--- code ---
if(!lphModule)
{
  cb = 0;
}
--- end code ---

With this code, the K32EnumProcessModules() call succeeds, but after that
PnkBstrB.exe tries to read at the NULL pointer and crashes anyway.

So I used this code instead:

--- code ---
if(!lphModule)
{
    SetLastEror(ERROR_NOACCESS);
    return FALSE;
}
--- end code ---

With that code, PnkBstrB.exe does not crash. It loads fine when the game
starts.
I could play the game 3 hours long without getting kicked, and I could play
again today. The pbcl.log file shows that everything PunkBuster related is
working.