https://bugs.winehq.org/show_bug.cgi?id=56464
Jason Millard jsm174@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jsm174@gmail.com
--- Comment #5 from Jason Millard jsm174@gmail.com --- (In reply to francisdb from comment #3)
In case somebody wants to implement this
https://github.com/vpinball/vpinball/blob/ 9cd01e63b6271b2cc59a180a7335093b2cfde200/standalone/inc/wine/dlls/vbscript/ global.c#L2887-L2989
But keep in mind that this fails when the first item is empty. (will be fixed on a later commit at the vpinball side)
In vpinball's implementation of GlobalJoin, we were forgetting to NULL out the conv_str in the loop.
This is fixed now. I'm sure if this was implemented in Wine, it would be done the right way. I took bits and pieces from all the other global string functions to hopefully make the code similar.