[Bug 28332] Wazzal 1.2 (2002 release) crashes after clicking 'Play'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=28332

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |4807a8f588c67e2296474399368
                   |                            |a96c0046120fd
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #19 from Anastasius Focht  ---
Hello Gijs,

yes, this is fixed by commit
https://source.winehq.org/git/wine.git/commitdiff/4807a8f588c67e229647439936...
("quartz: Only return S_FALSE in IEnumFilters::Skip() if count goes past the
end of the sequence.").

Thanks.

With bug 50171 fixed as well (stack alignment on entry point for 32-bit PE
build), the intro animation no longer crashes.

--- snip ---
...
0130:trace:quartz:FilterGraph2_AddSourceFilter graph 01710570, filename
L"sound/music0.mp3", filter_name L"sound/music0.mp3", ret_filter 00AC09FC.
0130:trace:quartz:FilterGraph2_AddSourceFilter Using source filter
{e436ebb5-524f-11ce-9f53-0020af0ba770}.
0130:trace:quartz:DllGetClassObject
({e436ebb5-524f-11ce-9f53-0020af0ba770},{00000001-0000-0000-c000-000000000046},0031FA18)
0130:trace:quartz:DSCF_CreateInstance
(001A18D8)->(00000000,{56a86895-0ad4-11ce-b03a-0020af0ba770},0031FA1C)
0130:trace:quartz:async_reader_create Created file source 01711130.
0130:trace:quartz:FileSource_Load 01711130->(L"sound/music0.mp3", 00000000)
0130:trace:quartz:FilterGraph2_AddFilter graph 01710570, filter 01711130, name
L"sound/music0.mp3".
0130:trace:quartz:MediaControl_Stop graph 01710570.
0130:trace:quartz:MediaFilter_Stop graph 01710570.
0130:trace:quartz:FilterGraph2_EnumFilters graph 01710570, out 0031FB24.
0130:trace:quartz:FilterGraphInner_AddRef (01710570)->(): new ref = 4
0130:trace:quartz:EnumFilters_Skip enum_filters 026869D0, count 1.
0130:trace:quartz:EnumFilters_Skip enum_filters 026869D0, count 1.
0130:trace:quartz:EnumFilters_Reset enum_filters 026869D0.
0130:trace:quartz:EnumFilters_Next enum_filters 026869D0, count 1, filters
0031FB00, fetched 00000000.
0130:trace:quartz:EnumFilters_Next enum_filters 026869D0, count 1, filters
0031FB04, fetched 00000000.
0130:trace:quartz:EnumFilters_Release 026869D0 decreasing refcount to 0.
0130:trace:quartz:FilterGraphInner_Release (01710570)->(): new ref = 3
0130:trace:quartz:FilterGraph2_RemoveFilter (01710570/01710574)->(01711130)
0130:trace:quartz:FilterGraph2_RemoveFilter Removing filter
L"sound/music0.mp3".
0130:trace:quartz:FilterGraph2_AddFilter graph 01710570, filter 01711130, name
(null).
0130:trace:quartz:FilterGraph2_Render graph 01710570, source 01711280.
0130:trace:quartz:autoplug Trying to autoplug 01711280 to 00000000, recursion
depth 0.
0130:trace:quartz:autoplug_through_filter Trying to autoplug 01711280 to
00000000 through 01711130.
0130:trace:quartz:autoplug_through_sink Trying to autoplug 01711280 to 00000000
through 01711280.
0130:trace:quartz:Inner_QueryInterface
(0241BE10)->({b79bb0b0-33c1-11d1-abe1-00a0c905f375}, 0031FA60)
0130:trace:quartz:FilterGraphInner_AddRef (01710570)->(): new ref = 4
0130:trace:quartz:FilterMapper3_EnumMatchingFilters (0031FA5C, 0, false,
400000, true, 1, 0031FA90, 00000000, 00000000, false, false, 00000000,
00000000, 00000000)
0130:trace:loaddll:build_module Loaded L"C:\windows\system32\avicap32.dll"
at 7A350000: builtin
0130:trace:loaddll:build_module Loaded L"C:\windows\system32\msdmo.dll" at
123B0000: builtin
0130:trace:loaddll:build_module Loaded L"C:\windows\system32\devenum.dll" at
12390000: builtin
0130:trace:quartz:FilterMapper3_EnumMatchingFilters Considering category
L"DirectShow Filters"
0130:trace:quartz:FilterMapper3_EnumMatchingFilters Considering filter L"MP3
Decoder DMO" 
...
0130:trace:quartz:enum_moniker_Next iface 017114B8, count 1, filters 0031FA4C,
ret_count 00000000.
01ec:trace:loaddll:build_module Loaded
L"C:\windows\system32\winegstreamer.dll" at 72FB0000: builtin
0130:trace:quartz:FilterGraph2_AddFilter graph 01710570, filter 02688D88, name
L"GStreamer splitter filter".
0130:trace:quartz:autoplug_through_filter Trying to autoplug 01711280 to
00000000 through 02688D88.
0130:trace:quartz:autoplug_through_sink Trying to autoplug 01711280 to 00000000
through 02688ED8.
0130:trace:quartz:FilterGraph2_ConnectDirect (01710570/01710574)->(01711280,
02688ED8, 00000000)
0130:trace:quartz:FilterGraph2_ConnectDirect Filter owning ppinIn(01711280) =>
01711130 
...
--- snip ---

I wrote a small AutoHotkey script which automates the (crash) testing of the
game. Handy to run against a range of Wine versions. Forgot to mention it in my
previous comments.

Prerequisite: 'winetricks -q autohotkey'

'wazzal.ahk':

--- snip ---
; run script / game in virtual desktop mode to handle graphics resolution
restore after crashes
; wine explorer.exe /desktop=dummy,1024x768 "c:\Program Files
(x86)\AutoHotkey\AutoHotkey.exe" wazzal.ahk

FileDelete, c:\wazzal.fail

Run, c:\Program Files (x86)\Wazzal\Wazzal.exe, c:\Program Files (x86)\Wazzal
WinWait, ahk_class Browser Example,,10
if ErrorLevel
{
    FileAppend,, c:\wazzal.fail
    Exit
}
Sleep, 5000
ControlClick, Button2
Loop, 20
{
    Sleep, 1000
    Process, Exist, winedbg.exe
    If ErrorLevel
    {
        FileAppend,, c:\wazzal.fail
        Process, Close, winedbg.exe
        Exit
    }
}
Process, Close, Wazzal.exe 
--- snip ---

--- snip ---
$ wine explorer.exe /desktop=dummy,1024x768 "c:\Program Files
(x86)\AutoHotkey\AutoHotkey.exe" wazzal.ahk 2>&1 | grep debugger ; \
    [ -f ~/.wine/drive_c/wazzal.fail ] && echo "Game failed (crashed)!" || echo
"Game startup ok."

Game startup ok. 
--- snip ---

$ wine --version
wine-5.22-39-g4807a8f588c

Regards