[Bug 23708] winemenubuilder:SaveIconResAsPNG unsupported bpp 21060, please report

http://bugs.winehq.org/show_bug.cgi?id=23708

--- Comment #4 from Damjan Jovanovic   2010-08-26 14:52:20 ---
Created an attachment (id=30415)
 --> (http://bugs.winehq.org/attachment.cgi?id=30415)
Read the embedded PNG

This patch should read the embedded PNG. But it doesn't work (+wincodecs gives
warn:wincodecs:user_error_fn PNG error: "Not a PNG file").

There could be several problems:
1. The embedded file is not a PNG.
2. The embedded PNG is corrupt.
3. winemenubuilder doesn't correctly convert module resource icons to an
IStream.
4. windowscodecs doesn't parse PNGs correctly.

Testing extraction from the icon instead of the executable gives the same
problem, disproving case 3.

Testing an equivalent patch to Sanselan (http://commons.apache.org/sanselan/)
correctly extracts a beautiful PNG, disproving options 1 and 2.

So that leaves:
4. windowscodecs doesn't parse PNGs correctly.
OR
5. the PNG is subtly broken, Sanselan's custom PNG parser gets through it, but
libpng chokes.

Any ideas Vincent?