[Bug 54292] New: Dumping shaders using VKD3D_SHADER_DUMP_PATH= fails with the bundled vkd3d

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54292

Bug ID: 54292
           Summary: Dumping shaders using VKD3D_SHADER_DUMP_PATH= fails
                    with the bundled vkd3d
           Product: Wine
           Version: 8.0-rc3
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The problem is in the bundled vkd3d, couldn't find the corect component for
that.

Also I'm using a PE enabled build (if that is relevant).

IIUC the bundled vkd3d code is built against the windows runtime and therefore
the shader dump path requires backslash instead of slash.

The following patch seems to be enough to restore functionality

diff --git a/libs/vkd3d/libs/vkd3d-shader/vkd3d_shader_main.c
b/libs/vkd3d/libs/vkd3d-shader/vkd3d_shader_main.c
  index 7e153bce27a..4c0aa48aa55 100644
  --- a/libs/vkd3d/libs/vkd3d-shader/vkd3d_shader_main.c
  +++ b/libs/vkd3d/libs/vkd3d-shader/vkd3d_shader_main.c
  @@ -376,7 +376,7 @@ static void vkd3d_shader_dump_blob(const char *path,
const char *prefix,

id = InterlockedIncrement(&shader_id) - 1;

-    snprintf(filename, ARRAY_SIZE(filename), "%s/vkd3d-shader-%s-%u.%s",
path, prefix, id, suffix);
  +    snprintf(filename, ARRAY_SIZE(filename), "%s\vkd3d-shader-%s-%u.%s",
path, prefix, id, suffix);
       if ((f = fopen(filename, "wb")))
       {
           if (fwrite(data, 1, size, f) != size)

I think it would also be nice to print failure details on the failure path.