[Bug 42625] fixme:commdlg: GetOpenFileName16 custom hook 0x17a7053e no longer supported

https://bugs.winehq.org/show_bug.cgi?id=42625

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |comdlg32
           Keywords|                            |regression
            Product|Wine-staging                |Wine

--- Comment #3 from Sebastian Lackner  ---
(In reply to Chris Parker from comment #0)
> In the console,
> the error message is "fixme:commdlg:GetOpenFileName16 custom hook 0x17a7053e
> no longer supported".  This is really bad!

The 16-bit implementation hasn't been changed since a long time, this message
was already before. Please provide additional information how to reproduce this
issue and add a log.

Nevertheless, my guess would be that its caused by:

https://source.winehq.org/git/wine.git/patch/c23a91cb638262f1d60f4437650c744...

It looks like after the change nMaxFile is ignored for A strings:

--- snip ---
    ofnW.lpstrFile = heap_strdupAtoW(ofn->lpstrFile);
--- snip ---

And the W-function also has a bug (should allocate one more char or use
memcpy):

--- snip ---
    if (ofn->lpstrFile)
    {
        info->filename = MemAlloc(ofn->nMaxFile * sizeof(WCHAR));
        lstrcpynW(info->filename, ofn->lpstrFile, ofn->nMaxFile);
    }
--- snip ---