https://bugs.winehq.org/show_bug.cgi?id=39377
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED URL|http://www.skysagaonline.co |https://web.archive.org/web |m/download/SkySagaEUInstall |/20210714052551/http://www. |er.exe |skysagaonline.com/download/ | |SkySagaEUInstaller.exe
--- Comment #2 from Anastasius Focht focht@gmx.net --- Hello folks,
revisiting. It seems the original download site came back to life again. I promptly created a snapshot of the installer via Internet Archive.
https://web.archive.org/web/20210714052551/http://www.skysagaonline.com/down...
$ sha1sum SkySagaEUInstaller.exe ee55d51213031fdf8d71475434c18ecd7caef9eb SkySagaEUInstaller.exe
$ du -sh SkySagaEUInstaller.exe 11M SkySagaEUInstaller.exe
Turns out this was fixed a long time ago, contrary to my comment #1.
Reverse bisecting didn't work. Between Wine 2.11 (bad) and Wine 2.20 (good) there were multiple msi regressions which causes the installer to crash.
The first crash was introduced with:
https://source.winehq.org/git/wine.git/commitdiff/48237e249b76f5ad883ec073e3... ("msi: Add a basic internal UI implementation.")
Part of Wine 2.12
Installer UI became usable again without crash after commit https://source.winehq.org/git/wine.git/commitdiff/c14a16b08911d1695e42b75c60... ("user32: Implement IDI_SHIELD.").
Part of Wine 2.20
At that point the dialog showed the disk space properly formatted. That's obviously not the fix commit. Something in between:
--- snip --- $ git log --oneline 48237e249b7^...wine-2.20 -- dlls/msi | grep -v tests
9ce8592b068 msi: Add error handling when retriving component/feature state/action in condition. dcd92a168b3 msi: Store condition intermediate values in union. c8d32b69ec4 msi: Define special types for condition operators, identifiers and expressions. 024c6c1b4b9 msi: Move condition integer handling into value_i. 599622d5832 msi: Add install test with no arguments on already installed product. a6ad46dc940 msi: Don't leak memory on failure. f621f4102d6 msi: Don't leak memory on failure. 808f3158bbc msi: Improve installation with no argument of already installed product. c41b8ce5c36 msi: Improve "full uninstall" detection code. b141a145c49 msi: Improve feature action value evaluation in conditions. 30c957b9ccb msi: Fix installations with only INSTALLSTATE_SOURCE features. f517022ecc8 msi: Fix an invalid write in build_default_format (Valgrind). af9ee877488 msi: Add a missing UI message in the ExecuteAction action. 4a2809166c4 msi: Remove redundant NULL checks before msi_free(). fdac39f697e msi: Pass correct length to GetDateFormatW. e1e668d41fc msi: Store the current script in the package. 5245b9d3a85 msi: Remove a superfluous substructure. 86bc556f9fd msi: Don't execute a deferred custom action when not running the install script. 92118091f8e msi: Perform the given action, or INSTALL, from MsiInstallProduct(). 26493d316c1 msi: Implement the INSTALL top-level action. 5c39852c1e7 msi: More fully implement the ExecuteAction action. d17fda090d2 msi: Simplify message type processing. eb79fe1c3b2 msi: Remove ACTION_PerformUIAction(). 52fbaeb2c44 msi: Add support for ActionText table. 700ebc86a9f msi: Return the correct values from dialogs. a3dd99c9a36 msi: Return the current date and time. 4ccc82a88ae msi: Use the Error table for more messages. 77e3d3372fd msi: Use MsiProcessMessage() to send error messages. 3ca2dfe4624 msi: Avoid uninitialized pointer access on error path (Coverity). d631714ca86 msi: Add a trailing linefeed to a FIXME() trace. 39c2ff02832 msi: Send the dialog created message in dialog_create(). 14f865e14fc msi: Don't queue a parent dialog to be shown in EndDialog. 8826584b1d7 msi: Process ShowDialog/EndDialog after all other control events. 44fb23dc328 msi: Don't set _BrowseProperty. b4c39f4e7c9 msi: Avoid a null pointer dereference. 51bd884384d msi: Properly parse empty format strings. 16f0dffd011 msi: Return the correct values from custom actions. f348c7c04c0 msi: Rewrite dump_record(). f9c68dfd920 msi: Use the given record for INSTALLMESSAGE_ACTIONDATA. c788ed858ed msi: Provide the result of the last action. 1505912ce14 msi: Allow setting NULL in MsiSetInteger(). f9f53fe624b msi: Correctly format the template field for MsiProcessMessage(). 3033daec111 msi: Implement UI messages for dialogs. 5da9250394f msi: Don't increment the refcount when creating dialogs. 48237e249b7 msi: Add a basic internal UI implementation. --- snip ---
Regards