[Bug 14052] CoreAudio driver broken

http://bugs.winehq.org/show_bug.cgi?id=14052

--- Comment #5 from Gaofeng Huang   2009-04-04 05:26:57 ---
Here, the last working version here is 0.9.57, although the message
"err:midi:CoreAudio_MIDIInit can't create wineMIDIClient" is also there, but
the audio is working.

Checking the diff shows that:
--- wine/dlls/winecoreaudio.drv/coreaudio.c     2008/03/12 11:45:57     1.4
+++ wine/dlls/winecoreaudio.drv/coreaudio.c     2008/03/12 11:45:58     1.5
@@ -42,9 +42,12 @@ WINE_DEFAULT_DEBUG_CHANNEL(coreaudio);
 static LRESULT CoreAudio_drvLoad(void)
 {
     TRACE("()\n");
-    CoreAudio_WaveInit();
-    CoreAudio_MIDIInit();
-    CoreAudio_MixerInit();
+
+    if (CoreAudio_WaveInit() != DRV_SUCCESS ||
+        CoreAudio_MIDIInit() != DRV_SUCCESS ||
+        CoreAudio_MixerInit() != DRV_SUCCESS)
+        return DRV_FAILURE;
+
     return DRV_SUCCESS;
 }

So my suggestion of temp solution is to revert back the coreaudio.c, because
the MIDI part is going to fail, but the rest is working.

NOTES: another interesting finding is that using WineHelper.app actually make
everything work. But I don't know what is the diff between commandline wine and
WineHelper.app that makes the MIDI part working.