[Bug 16834] SetFormat() doesn't remap unmapped sound buffers on failure

http://bugs.winehq.org/show_bug.cgi?id=16834

Raymond  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Raymond   2010-07-31 07:09:55 ---
(In reply to comment #1)
> Created an attachment (id=18542)

--> (http://bugs.winehq.org/attachment.cgi?id=18542) [details]
> strace log of Wine during Railroad Tycoon 2 startup
>
> WINEDEBUG=trace,+dsalsa,+dsound
>
> notice munmap() of 0x7c89c000 on line 15897 and open("/dev/snd/pcmC0D0p") on
> line 15893.

The point is ioctl(23, 0xc0684113, 0x132ad0)         = -1 EINVAL (Invalid
argument)

this error occur between line 203 and 227 but wine seem ignore the error and
continue

write(2, "trace:dsalsa:SetFormat Period siz"..., 43trace:dsalsa:SetFormat
Period size is: 512
) = 43
ioctl(23, 0x4140, 0x33ec7c)             = 0
write(2, "trace:dsalsa:DSDB_CreateMMAP mmap"..., 72trace:dsalsa:DSDB_CreateMMAP
mmap'd buffer is a direct hardware buffer.
) = 72
write(2, "trace:dsalsa:DSDB_CreateMMAP form"...,
108trace:dsalsa:DSDB_CreateMMAP format=S16_LE  frames=16384  channels=2 
bits_per_sample=16  bits_per_frame=32
) = 108
ioctl(23, 0xc0684113, 0x132ad0)         = -1 EINVAL (Invalid argument)
write(2, "trace:dsalsa:DSDB_CreateMMAP crea"..., 93trace:dsalsa:DSDB_CreateMMAP
created mmap buffer of 16384 frames (65536 bytes) at 0x7c89c000