[Bug 11936] window size is too small in the "vc2008 redist installer" and "Firefox 3" [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=11936

--- Comment #14 from Reece Dunn   2008-07-12 02:55:51 ---
(In reply to comment #13)
> I can't tell you why, but this helps here:

So the issue is fixed when not adjusting the top of the rect by SM_CYCAPTION,
or is there more?

#> --- a/dlls/user32/nonclient.c
> +++ b/dlls/user32/nonclient.c
> @@ -111,8 +111,8 @@ NC_AdjustRectOuter (LPRECT rect, DWORD style, BOOL menu,
> DWORD exStyle)
>      {
>          if (exStyle & WS_EX_TOOLWINDOW)
>              rect->top -= GetSystemMetrics(SM_CYSMCAPTION);
> -
>    else
> -
>        rect->top -= GetSystemMetrics(SM_CYCAPTION);
> -
>   // else
> -
>   //     rect->top -= GetSystemMetrics(SM_CYCAPTION);
> }
>    if (menu) rect->top -= GetSystemMetrics(SM_CYMENU);
>
> }

We should be able to use this information to write a test to verify that the
outer rect is not being decreased by SM_CYCAPTION on Windows.
> The fullscreen issue I mentioned in the last comment persists with this,
> though, so I think it is another bug.

Sure.