http://bugs.winehq.org/show_bug.cgi?id=32003
--- Comment #2 from François Gouget fgouget@codeweavers.com 2013-01-30 10:38:20 CST --- This is mostly done:
commit 4c266ab9e904222186b0fae0c28b190b80d22ce1 Author: Francois Gouget fgouget@codeweavers.com Date: Fri Nov 2 00:11:00 2012 +0100
testbot: Fix the Job and Step status update.
A job that has a non-build step fail should still be marked as failed. That's because when there are test failures the TestFailures field gets set to a non-zero value but the task's Status is still set to completed. So a failed Step really reflects a bot error. Also simplify the code and avoid duplicating the UpdateStatus() logic in the Check() method.
However now if a patch fails to apply or compile the job is marked as failed which may not be appropriate.