[Bug 29852] Star Trek Birth of the Federation - No Videos

https://bugs.winehq.org/show_bug.cgi?id=29852

--- Comment #14 from Dmitry Timoshkov  ---
(In reply to Bruno Jesus from comment #13)
> Dmitry, I found something new. The game is calling ICLocate [1] with the
> negative height in the LPBITMAPINFOHEADER lpbiOut.
>
> The game installs its own iccvid.dll inside the game folder, on XP I deleted
> this dll and the video NO longer plays (the game requires an older version
> of iccvid to work). In wine I forced iccvid as native (confirmed by not
> having debug traces anymore) to check if videos would render and they ARE
> displayed correctly. So:
>
> XP + system32 iccvid = NO VIDEO
> XP + game iccvid     = GOOD VIDEOS
> Wine + built iccvid  = NO VIDEO (due to negative biHeight check)
> wine + game iccvid   = GOOD VIDEOS
>
> This bug could be potentially invalid but it looks like wine iccvid could
> still cope with negative biHeights like the old versions of iccvid, I see no
> harm in that.

Probably it's worth to write some tests first.