[Bug 54822] New: ddraw:visual - createObjects() crashes on fg-deb64 (Intel GPU)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54822

Bug ID: 54822
           Summary: ddraw:visual - createObjects() crashes on fg-deb64
                    (Intel GPU)
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 74321
  --> https://bugs.winehq.org/attachment.cgi?id=74321
ddraw/tests: Prevent the visual tests from crashing the X server on Intel GPUs.

ddraw:visual - createObjects() crashes on fg-deb64 (Intel GPU[1]):

ddraw:visual start dlls/ddraw/tests/visual.c
ddraw:visual:06d0 done (0) in 2s 0B

See https://test.winehq.org/data/patterns.html#ddraw:visual

So this is a case of premature exit. A look at the logs immediately reveals the
cause of the silent crash:

X Error of failed request:  BadValue (integer parameter out of range for
operation)
  Major opcode of failed request:  140 (RANDR)
  Minor opcode of failed request:  7 (RRSetScreenSize)
  Value in failed request:  0x0
  Serial number of failed request:  35
  Current serial number in output stream:  36

Running the test with WINETEST_REPORT_SUCCESS=1 and adding some traces shows
the X error happens on this createObjects() line:

112   hr = IDirectDraw7_SetDisplayMode(DirectDraw, 640, 480, 32, 0, 0);

Replacing the 32 bit depth with 24 results in the call returning 0x80004001
(E_NOTIMPL) instead of crashing (that's an odd error code btw). So an easy
workaround would be to use the attached patch.

However:
* This causes most (if not all) of the tests to be skipped.
* My GPU and screen do support 640x480.
* Also running ddraw:visual from my development tree results in 0 skips and 0
failures!

So getting successful runs should be possible (just not in the 3 clean
out-of-tree builds I use to run WineTest :-( ). It's either a matter of
figuring out which is the miraculous patch or where the memory corruption comes
from.

[1] This is an Intel HD Graphics 4600 GPU (comes in the i7-4790K CPU).