http://bugs.winehq.org/show_bug.cgi?id=10640
Summary: Change to modern Windows colours - not enough Product: Wine Version: 0.9.50. Platform: Other OS/Version: other Status: UNCONFIRMED Severity: minor Priority: P2 Component: wine-user AssignedTo: wine-bugs@winehq.org ReportedBy: bammzilla@gabriana.com
While I appreciate (and love) the patch by Alexander Nicolaysen Sørnes entitled "user32: Change to modern Windows colours", I think the change is not enough.
I did a fresh install of Windows XP, and compared the colors found in the patch for DefSysColors to the Windows XP registry key "HKEY_CURRENT_USER\Control Panel\Colors" and found that the following still need to be changed:
"ActiveTitle" from "0 0 128" to "10 36 106" "ButtonDkShadow" from "0 0 0" to "64 64 64" "ButtonLight" from "224 224 224" to "212 208 200" "GradientActiveTitle" from "16 132 208" to "166 202 240" "GradientInactiveTitle" from "181 181 181" to "192 192 192" "Hilight" from "0 0 128" to "10 36 106" "MenuHilight" from "0 0 0" to "10 36 106"
In addition, Windows XP's registry contains the following entries not found in Wine's DefSysColors function:
"ButtonAlternateFace"="181 181 181" "HotTrackingColor"="0 0 128" "InfoBorder"="41 3 2" "InfoText"="0 0 0" "InfoWindow"="255 255 225"
Although Wine does not use the additions yet, it might be useful to have them too in case future enhancements to Wine needs them.
I also suggest that the entries be arranged alphabetically for people browsing the code to easily find what they are looking for.
I therefore suggest the following content for the DefSysColors function, properly alphabetized:
static const char * const DefSysColors[] = { "ActiveBorder", "212 208 200", /* COLOR_ACTIVEBORDER */ "ButtonAlternateFace", "181 181 181" /* COLOR_BUTTONALTERNATEFACE */ "ActiveTitle", "0 0 128", /* COLOR_ACTIVECAPTION */ "AppWorkSpace", "128 128 128", /* COLOR_APPWORKSPACE */ "Background", "0 128 128", /* COLOR_BACKGROUND */ "ButtonDkShadow", "0 0 0", /* COLOR_3DDKSHADOW */ "ButtonFace", "212 208 200", /* COLOR_BTNFACE */ "ButtonHilight", "255 255 255", /* COLOR_BTNHIGHLIGHT */ "ButtonLight", "224 224 224", /* COLOR_3DLIGHT */ "ButtonShadow", "128 128 128", /* COLOR_BTNSHADOW */ "ButtonText", "0 0 0", /* COLOR_BTNTEXT */ "GradientActiveTitle", "16 132 208", /* COLOR_GRADIENTACTIVECAPTION */ "GradientInactiveTitle", "181 181 181", /* COLOR_GRADIENTINACTIVECAPTION */ "GrayText", "128 128 128", /* COLOR_GRAYTEXT */ "Hilight", "0 0 128", /* COLOR_HIGHLIGHT */ "HilightText", "255 255 255", /* COLOR_HIGHLIGHTTEXT */ "HotTrackingColor", "0 0 128" /* COLOR_HOTTRACKINGCOLOR */ "InactiveBorder", "212 208 200", /* COLOR_INACTIVEBORDER */ "InactiveTitle", "128 128 128", /* COLOR_INACTIVECAPTION */ "InactiveTitleText", "212 208 200", /* COLOR_INACTIVECAPTIONTEXT */ "InfoBorder", "41 3 2" /* COLOR_INFOBORDER */ "InfoText", "0 0 0" /* COLOR_INFOTEXT */ "InfoWindow", "255 255 225" /* COLOR_INFOWINDOW */ "Menu", "212 208 200", /* COLOR_MENU */ "MenuBar", "212 208 200" /* COLOR_MENUBAR */ "MenuHilight", "0 0 0", /* COLOR_MENUHILIGHT */ "MenuText", "0 0 0", /* COLOR_MENUTEXT */ "Scrollbar", "212 208 200", /* COLOR_SCROLLBAR */ "TitleText", "255 255 255", /* COLOR_CAPTIONTEXT */ "Window", "255 255 255", /* COLOR_WINDOW */ "WindowFrame", "0 0 0", /* COLOR_WINDOWFRAME */ "WindowText", "0 0 0", /* COLOR_WINDOWTEXT */ };
other files touched by Alexander's patch should be updated accordingly, such as display.rc, etc.