https://bugs.winehq.org/show_bug.cgi?id=38485
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #9 from super_man@post.com --- (In reply to Austin English from comment #8)
(In reply to André H. from comment #7)
(In reply to Mike Ellery from comment #6)
Thanks for the feedback, I've attached an update.
LPDHCPCAPI_CLASSID, DHCPCAPI_PARAMS_ARRAY, DHCPCAPI_PARAMS_ARRAY, LPBYTE, LPDWORD should also be marked as ptr in the specfile We also try to avoid lines longer than 100 characters, i suggest to shorten the parameter names and add line breaks The typedefs you added should maybe go to a new include/dhcpcsdk.h, but maybe it get's accepted this way as you only add a stub We use 4 space indentation, your typedefs don't... You also should use WINAPI instead of APIENTRY
I think it's worth the try sending it to the mailinglist directly after fixing these issues. Thx for the effort
I cleaned it up and submitted it: https://source.winehq.org/patches/data/115782
patching file dlls/dhcpcsvc/dhcpcsvc.c patching file dlls/dhcpcsvc/dhcpcsvc.spec
against 1.9.4-git