[Bug 25749] TortoiseSVN (TortoiseProc.exe) crashes upon exit (OLE teardown)

http://bugs.winehq.org/show_bug.cgi?id=25749

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
            Summary|TortoiseSVN fails after     |TortoiseSVN
                   |successful commit           |(TortoiseProc.exe) crashes
                   |                            |upon exit (OLE teardown)
     Ever Confirmed|0                           |1

--- Comment #12 from Anastasius Focht  2011-04-26 11:41:22 CDT ---
Hello,

confirming, crashes on exit.
This issue does not only apply to commits, you can also reproduce with other
commands.

Fun fact: it seems using builtin msvcr90 prevents the crash at the end.
This is most likely due to some stuff not really implemented/stubbed...

WINEDLLOVERRIDES="msvcr90=b" wine "C:\Program
Files\TortoiseSVN\bin\TortoiseProc.exe" /command:commit .

Crash:

WINEDLLOVERRIDES="msvcr90=n" wine "C:\Program
Files\TortoiseSVN\bin\TortoiseProc.exe" /command:commit .

The code where the crash occurs is most likely the following
(CrashRpt.UninstallEx -> in CCrashHandler destructor):

https://tortoisesvn.googlecode.com/svn/trunk/src/crashrpt/CrashHandler.cpp

The crash is triggered in ole32.CoUninitialize() teardown.

There are at least 6 open bugs when searching for that offending "cross process
drap & drop" commit:

http://bugs.winehq.org/buglist.cgi?query_format=advanced&bug_status=UNCO...

--- snip ---
0009:Call ole32.RegisterDragDrop(00010086,00ee28b0) ret=00e8c817 
...
0009:Ret  ole32.RegisterDragDrop() retval=00000000 ret=00e8c817
...
0009:Call ole32.RegisterDragDrop(00010088,00bf53a8) ret=00460ac9 
...
0009:Ret  ole32.RegisterDragDrop() retval=00000000 ret=00460ac9
...
0009:Call ole32.RevokeDragDrop(00010086) ret=00e8c06a
...
0009:Ret  ole32.RevokeDragDrop() retval=00000000 ret=00e8c06a
0009:Call ole32.OleUninitialize() ret=00e8f051
0009:Ret  ole32.OleUninitialize() retval=00000000 ret=00e8f051 
...
0009:CALL CrashRpt.UninstallEx(<unknown, check return>) ret=0070e389 
...
0009:Call ole32.CoUninitialize() ret=02001459 
...
*boom*
--- snip ---

Revoke is only called for one window before OLE is teared down finally.

Reverting back to old behavior in RegisterDragDrop() and RevokeDragDrop()
prevents the crash.
Other bugs might be dupes of each other.

Regards