[Bug 40460] winetricks xna31 and dotnet20sp2 fail

https://bugs.winehq.org/show_bug.cgi?id=40460

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTOURBUG
             Status|NEW                         |RESOLVED

--- Comment #7 from Austin English  ---
(In reply to Sebastian Lackner from comment #6)
> When I just call "winetricks xna31" I'm still not able to see any kind of
> failure here on my machine. However, I played around a bit more, and when I
> add the "-q" switch it indeed fails. Is that also what you guys use?

Yes, my mistake, I had included that originally. GUIs are for suckers :p
> On the first sight, it seems to be a race-condition in winetricks.
> Installation of dotnet20sp2 is started before dotnet20 is fully finished.
> Before the commit, RegNotifyChangeKeyValue always returned immediately with
> a failure, now the application will properly wait. Those timing differences
> are probably what causes the "regression".

Nice find.
> Proposed change for winetricks:
>
> --- snip ---
> --- a/src/winetricks
> +++ b/src/winetricks
> @@ -5800,6 +5800,7 @@ load_dotnet20sp2()
>      w_call remove_mono
>  w_call dotnet20
> -
>
> $WINESERVER -w
>
> # FIXME: verify on pristine windows XP:
> if w_workaround_wine_bug 34803
>
> --- snip ---

That wasn't enough for me, I also tried it after both w_call dotnet20 and the
dotnet20sp2 installer, but that only works sometimes.
> BTW: At some places winetricks uses $DRIVE_C which looks like an undefined
> variable to me.

It's set in winetricks_set_wineprefix(), which is called from w_do_call().