http://bugs.winehq.org/show_bug.cgi?id=16325
--- Comment #3 from Xiangrong Fang xrfang@gmail.com 2008-12-04 05:55:28 --- (In reply to comment #2)
The patches like you've attached touch a very important part of the gdi32 code, and at the very least a test case confirming that the change is correct is required.
I realized this, and since I am not an experience linux developer, 99% of this patch is from replies of bug #4605. However, my modification makes sure that if environment variable WINE_DEFAULT_CODEPAGE is not set, it absolutely affect nothing of the code. This is at least a TEMPORARY improvements which benefits all CJK users. By default, there is no such env, so it will never affect any user, that's why I think it is clear and not need much testing...?
A tiny possibility is "name space pollution". i.e. arbitrarily adding control switches to env... but 1) the code is marked with a FIXME, it is meant to be a temp solution; 2) the switch's meaning is very clear, I don't think anyone will by coincidence use this variable to mean something else?
Sorry if I am wrong, I am learning what is necessary procedure to submit a patch with the help from Dan Kegel.