https://bugs.winehq.org/show_bug.cgi?id=47265
--- Comment #36 from Andrew Wesie awesie@gmail.com --- (In reply to Alistair Leslie-Hughes from comment #35)
The code prior to the regression (3e927c) did not have DECLSPEC_HOTPATCH. I think there would need to be some justification for why this change is necessary.
However 13e11d3fcbcf8790e031c4bc52f5f550b1377b3b did.
-ULONGLONG WINAPI DECLSPEC_HOTPATCH get_tick_count64(void) +ULONG WINAPI NtGetTickCount(void)
It was removed because it was no longer necessary. 3e927c made the unfortunate choice of relaying GetTickCount to NtGetTickCount. Since GetTickCount had DECLSPEC_HOTPATCH, the commit's author applied DECLSPEC_HOTPATCH to NtGetTickCount as well.
With the corrected version, 13e11d, GetTickCount is a separate function and has DECLSPEC_HOTPATCH. As such, NtGetTickCount can go back to its previous form. I'm not even convinced that DECLSPEC_HOTPATCH on NtGetTickCount does anything on wine-staging due to the syscall wrappers.
As far as testing, I compiled Wine-staging v4.9 + 13e11d + d88c40, and I had no issues starting Starcraft Remastered, Overwatch, nor World of Warcraft (without d3d12).