https://bugs.winehq.org/show_bug.cgi?id=50491
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Fixed by SHA1| |4ddd1988c59548839c1c19e146e | |a213ecd0e74d3
--- Comment #1 from François Gouget fgouget@codeweavers.com --- This is fixed. Now only the 'clean' part of the error line is put in the .errors file so comparison with past instances can match. This also means the JobDetails page only shows the 'clean' part of the error but then when one expands to see the full log the raw line is shown. Note that it can still be matched to the .errors entry thanks to the line number, which means it is highlighted as expected.
commit 4ddd1988c59548839c1c19e146ea213ecd0e74d3 Author: Francois Gouget fgouget@codeweavers.com Date: Mon Mar 22 11:12:15 2021 +0100
testbot/LogUtils: Don't include garbage in the .errors file.
When failure lines are garbled because of a race condition or a missing '\n' they often contain unwanted characters at the start of the line. If included in the .errors file these prevent the line from matching past instances of the failure (if only because of line numbers), thus causing it to be incorrectly reported as new. So only include the parts of the line matched by the error matching regular expression.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50491 Signed-off-by: Francois Gouget fgouget@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org