http://bugs.winehq.org/show_bug.cgi?id=17896
Rafał Mużyło galtgendo@o2.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |galtgendo@o2.pl
--- Comment #8 from Rafał Mużyło galtgendo@o2.pl 2012-06-12 12:02:30 CDT --- (In reply to comment #7)
Matias: Jerome meant to send the patch in git format to wine-patches, see http://wiki.winehq.org/SubmittingPatches for more info. (Patches are not picked up from bugzilla) I checked that the change is OK and also works on Linux, still you need to get the latest git version of wine, apply the change and send it to make sure it applies.
That's not quite correct. This is not a no-op, as due to brokenness of cups-config, this will cause overlinking (unless you decide to rely on -Wl,--as-needed). Actually, I'd say that the original case is broken, as the lib is underlinked.
I.e., here 'cups-config --libs' returns '-lcups -L/usr/lib -lgssapi -lheimntlm -lkrb5 -lhx509 -lasn1 -lwind -lheimbase -lroken -pthread -lssl -lcrypto -lz -lpthread -lcrypt -lm'.
While indeed it should have been 'cups-config --libs' in the first place, cause 'cups-config --ldflags' returns '' here, some filtering would be advised, as if libcups is build properly, it should be all that's needed to be added.