https://bugs.winehq.org/show_bug.cgi?id=50771
--- Comment #7 from Zeb Figura z.figura12@gmail.com --- The thing that seems questionable to me about the wine-staging patch is that it changes permissions. I'm not sure we want to do that, especially given the (theoretical) prospect that the user might not be able to do that anyway.
(Is it possible to omit FILE_SHARE_* flags if you don't have the corresponding access flags? Do we need to respect that? Seems like a security hole on Windows if so...)
(In reply to Joel Holdsworth from comment #5)
I might find time to attempt these changes, but what is the policy for evolving other people's patches? Is there a label I can put on for dual authorship? Would I make my changes as a seperate patch? Or just rewrite the patch, and submit it as my own work?
The general practice is to either submit the patch under the name of the original author, or write a new patch with something like "Based on a patch by X" in the subject.
(In reply to Joel Holdsworth from comment #6)
This looks like good stuff. What is the process for submitting these? If I want these to go upstream, should I submit a GitLab MR? Or ask the authors or wine-staging maintainers to submit? Is the patch in staging because it was once rejected? Is there any way to find out why it wasn't approved years ago?
The majority of patches in wine-staging were written by the original wine-staging maintainers, Michael Müller and Sebastian Lackner. While they did submit many patches upstream (successfully or unsuccessfully), they also wrote many patches which were never submitted upstream. They also largely disappeared several years ago, and attempts to contact them are rarely successful.
This patch in particular does seem to have been sent upstream in April 2015, but judging from wine-patches and wine-devel archives it never received an on-list review.